Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: create new amplify-prompts package to handle all terminal interactions" #7870

Closed
wants to merge 1 commit into from
Closed

Revert "feat: create new amplify-prompts package to handle all terminal interactions" #7870

wants to merge 1 commit into from

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Aug 3, 2021 •
edited by akshbhu
Loading

@sundersc sundersc requested a review from a team as a code owner August 3, 2021 20:20
edwardfoyle
edwardfoyle suggested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be merged instead: https://github.com/aws-amplify/amplify-cli/pull/7871/files

@codecov-commenter
Copy link

Codecov Report

Merging #7870 (2224871) into master (fbc7ff1) will increase coverage by 0.00%.
The diff coverage is 47.61%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7870   +/-   ##
=======================================
  Coverage   53.37%   53.38%           
=======================================
  Files         556      557    +1     
  Lines       28146    28159   +13     
  Branches     5455     5455           
=======================================
+ Hits        15024    15033    +9     
- Misses      12136    12140    +4     
  Partials      986      986
Impacted Files Coverage Δ
packages/amplify-cli/src/initialize-env.ts 11.94% <0.00%> (ø)
...earchable-transformer/src/generate-resolver-vtl.ts 66.66% <ø> (ø)
...y-provider-awscloudformation/src/push-resources.ts 9.80% <0.00%> (ø)
packages/amplify-cli-core/src/utils/fileSize.ts 30.76% <30.76%> (ø)
...amplify-cli-core/src/state-manager/stateManager.ts 39.73% <100.00%> (ø)
packages/amplify-cli-core/src/utils/index.ts 100.00% <100.00%> (ø)
...-graphql-searchable-transformer/src/definitions.ts 98.18% <100.00%> (-0.04%) ⬇️
...el-transformer/src/__tests__/test-utils/helpers.ts 85.71% <0.00%> (+17.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5952f6a...2224871. Read the comment docs.

@cjihrig
Copy link
Contributor

cjihrig commented Aug 4, 2021

Closing as the issues were resolved in #7871. If I'm wrong, please reopen.

@cjihrig cjihrig closed this Aug 4, 2021
@cjihrig cjihrig self-assigned this Aug 4, 2021
@aws-eddy aws-eddy deleted the revert-7774-amplify-prompts branch November 21, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfoyle edwardfoyle edwardfoyle requested changes

@akshbhu akshbhu akshbhu approved these changes

Assignees

@cjihrig cjihrig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sundersc @codecov-commenter @cjihrig @edwardfoyle @akshbhu